On 03/23/2015 12:18 PM, Carl Meyer wrote:
> On 03/23/2015 11:48 AM, Tim Graham wrote:
>> The alternative to a new setting would be to revert the "merging"
>> behavior of the django.utils.log.DEFAULT_LOGGING and settings.LOGGING
>> entirely. This original design was proposed by Claude in
>> https://code.djangoproject.com/ticket/18993#comment:7, but now we
>> realize disable_existing_loggers=True doesn't work as expected in that
>> proposal. I also find that writing a nice configuration that uses
>> disable_existing_loggers=False and that merges nicely with Django's
>> defaults to be difficult (for example, in trying to output all log
>> entries to the console, some as simple as the config below [1] won't
>> work because Django's DEFAULT_LOGGING has handlers for 'django.request'
>> and 'django.security' which don't propagate their entries (I couldn't
>> tell the reason for this from
>> https://github.com/django/django/commit/f0f327bbfe1caae6d11fbe20a3b5b96eed1704cf#diff-246800ac266982b8ad12f505352a662eR63)

[...]

> ISTM that "layer atop the default config" is a better default behavior
> if you add a LOGGING setting than "replace the default config", to avoid
> people losing their mail-admins config accidentally. (But we definitely
> need first-class support for "replace the default config" as an option,
> too.)

Also worth noting that reverting to "always replace the default config
if you have settings.LOGGING set" at this point would be a significant
backwards-incompatible change, that could result in people suddenly and
silently losing their admin error emails on upgrade.

Carl

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/55105997.8060001%40oddbird.net.
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to