Hello Marcin,
There’s an obvious bug here: silenced checks are still printed out — even
though they don’t prevent Django from starting.
I hadn’t understood that from your earlier messages. It shouldn’t be very hard
to fix.
If you want to make sure we don’t lose track of this bug, you should file a
ticket.
--
Aymeric.
> On 25 août 2015, at 15:46, Marcin Nowak <marcin.j.no...@gmail.com> wrote:
>
> Thanks for replies, Carl, Adam, Shai.
>
> But I think you're worrying too much for too many things. You're trying to
> control everything, trying to replace automated tests with system check
> framework, trying to block "invalid" operations, etc, etc. This is bad way,
> IMO.
>
> Let's see a small example how system check framework works:
>
> 1. I'm adding custom field to user (by patching User models, don't ask why -
> other ways does not work)
>
> class MyAppConfig(AppConfig):
> name = 'my app'
>
> def ready(self):
> from django.contrib.auth.models import User
> from django.db import models
>
> User.add_to_class('is_verified', models.BooleanField(default=False))
>
> 2. I'm adding new field to admin interface
>
> @admin.register(User)
> class MyUserAdmin(UserAdmin):
> [...]
> list_filter = ('is_superuser', 'is_active', 'is_verified')
> [...]
>
> 3. Django raises an error:
>
> ERRORS:
> <class 'myapp.admin.MyUserAdmin'>: (admin.E116) The value of 'list_filter[2]'
> refers to 'is_verified', which does not refer to a Field.
>
> Which is not true!
>
> 4. I'm silencing E116:
>
> SILENCED_SYSTEM_CHECKS = ['admin.E116']
>
> 5. Django starts, admin works (and new filter works also), but runserver
> still prints out a false message:
>
> Performing system checks...
>
> System check identified some issues:
>
> ERRORS:
> <class 'myapp.admin.MyUserAdmin'>: (admin.E116) The value of 'list_filter[2]'
> refers to 'is_verified', which does not refer to a Field.
>
> I know that this is unbelievable, Carl, but the message is displayed!
> And prints out untrue message at all...
>
> Sorry, but this is not helpful...
>
> BR,
> Marcin
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com
> <mailto:django-developers+unsubscr...@googlegroups.com>.
> To post to this group, send email to django-developers@googlegroups.com
> <mailto:django-developers@googlegroups.com>.
> Visit this group at http://groups.google.com/group/django-developers
> <http://groups.google.com/group/django-developers>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/7fef0c25-2706-4072-86d9-ca3e0dbc03c6%40googlegroups.com
>
> <https://groups.google.com/d/msgid/django-developers/7fef0c25-2706-4072-86d9-ca3e0dbc03c6%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout
> <https://groups.google.com/d/optout>.
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/8D382E82-7AF2-4FD4-B4DC-79101D75E9DE%40polytechnique.org.
For more options, visit https://groups.google.com/d/optout.
