Hi Shai, Apologies, I didn't fully process your suggestion or the reason for the flag the first time. I think it would work, though I'd be tempted to set the flag to False on the transition middleware by default, to provide perfect back-compat for existing uses of decorator_from_middleware until someone opts in by setting the flag to True or writing their own new-style middleware that doesn't inherit the mixin.
I'm still not entirely happy with this approach for the reason Tobias highlighted, though - it doesn't behave like someone might expect a view decorator to behave, and I think probably it should have an API that clarifies that what it's really doing is applying per-view middleware. Still halfway tempted to go with the original "make middleware authors responsible for this themselves, if they want to access response.content" approach. Carl -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/5769C70E.1010308%40oddbird.net. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: OpenPGP digital signature
