Thanks for the corrections and input. If I will keep the check and return False if the permission doesn't exist, will it be OK? If yes I think I have a good solution, I will return on the check if perm in Permission.all() So instead of: return True we will have: return perm in Permission.objects.all()
What do you think? If this seems reasonable I will make the PR in the next few days. On Sat, Sep 30, 2017 at 1:45 PM, Florian Apolloner <f.apollo...@gmail.com> wrote: > Hi, > > On Friday, September 29, 2017 at 7:00:41 PM UTC+2, moshe nahmias wrote: >> >> 3. Return False if the permission doesn't exist means that we go through >> the same path as a regular user, since (at least on >> auth.backends.ModelBackend) we check already if the user is superuser and >> if so we return all the permissions (I suppose it's only permissions that >> exist) it means we only need to remove the check at the start to see if the >> user is superuser. >> > > Removing this check would be highly backwards incompatible for 3rd party > permission backends. > > I don't think the performance will be that much of a problem, but since >> you think it might I think i will need to check it and report the results >> back unless there is a preference for one of the other solutions. either >> way it will be a good thing to check. >> > > There will probably not be a big performance drop for the builtin ones, > but we do not know anything about 3rd party (ie ldap etc) > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/django-developers/e14b6ff5-598d-4605-9e76- > 26df86971366%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/e14b6ff5-598d-4605-9e76-26df86971366%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CACf8pw7joMt29d%2Br9y3E6Kxfj9Jvm3g5J%2B1gqw6vmDWz1H5h2Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
