Just going to say that one of the main frustration points I've had when making a contribution is having to fix small formatting errors (often minor things in docstrings which aren't _always_ consistent).
It produces a lot of inertia and can stop PRs from getting merged for extended periods of time. So from a new contributor angle I think black is an obvious choice. >From a maintainers point of view, git blame is very nice to have and this would add some complexity. But it's easy to see the full version history of a file and, let's be honest, not enough people use git bisect. On Sun, 14 Apr 2019, 00:04 Berker Peksağ, <berker.pek...@gmail.com> wrote: > On Sun, Apr 14, 2019 at 1:34 AM Carlton Gibson <carlton.gib...@gmail.com> > wrote: > > > > We spend a lot of time spotting small formatting errors and then asking > for those to be fixed and then waiting for an update. This wastes reviewer > time and slows down the feedback cycle. Many pull requests drag out because > of it. > > But you can now do final edits (cosmetic changes, tweak reST markup > and documentation) via GitHub UI, right? I always do it to not bother > contributors with these changes, especially if they are new to the > project. > > --Berker > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAF4280J%2B6J1BJAto1MHd8mo5X%2Bm4AohSqS2HQr3yNXh1WOUcRQ%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAGuvt92sVXVAuTzLW7sQkpkJEdNuamfeQwjwcn2dvFokZDZ7CQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
