Am 15.08.2017 um 22:49 schrieb Timo Sirainen:
> https://dovecot.org/releases/2.2/rc/dovecot-2.2.32.rc1.tar.gz
my buildsystem complain on spelling errors
- in binaries
-> src/director/director-connection.c: reseting -> resetting
- in manpages
-> doc/man/doveadm-exec.1.in: wich -> which + No newline at end of file
patches attached.
one other point I notice (not new in this versions) are "warnings" from Debian
lintian:
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/auth
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called
N: by any routines, all unfortified calls have already been fully validated
N: at compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using
N: dpkg-buildflags directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Refer to https://wiki.debian.org/Hardening and
N: http://bugs.debian.org/673112 for details.
N:
N: Severity: normal, Certainty: wild-guess
N:
N: Check: binaries, Type: binary, udeb
N:
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/config
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/director
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/gdbhelper
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/imap
I: dv-dovecot: hardening-no-fortify-functions
usr/lib/dovecot/libdovecot-login.so.0.0.0
I: dv-dovecot: hardening-no-fortify-functions
usr/lib/dovecot/modules/lib10_quota_plugin.so
I: dv-dovecot: hardening-no-fortify-functions
usr/lib/dovecot/modules/lib20_fts_plugin.so
I: dv-dovecot: hardening-no-fortify-functions
usr/lib/dovecot/modules/lib20_replication_plugin.so
I: dv-dovecot: hardening-no-fortify-functions
usr/lib/dovecot/modules/lib99_welcome_plugin.so
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/quota-status
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/script
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/script-login
I: dv-dovecot: hardening-no-fortify-functions usr/lib/dovecot/xml2text
the text mention "CPPFLAGS" which occour exact two times in my Buildlog:
1. as parameter to configure
2. in that warning
I read this as "configure get an evironment variable "CPPFLAGS" and completely
ignore them.
full buildlog (for Debian Jessie, using aclocal-1.14, btw...) at
https://andreasschulze.de/tmp/dv-dovecot_2.2.32~rc1-2017081601_amd64.build.txt
Andreas
Description: lintian: wich -> which
Author: A. Schulze
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: dovecot-2.2.32~rc1/doc/man/doveadm-exec.1.in
===================================================================
--- dovecot-2.2.32~rc1.orig/doc/man/doveadm-exec.1.in
+++ dovecot-2.2.32~rc1/doc/man/doveadm-exec.1.in
@@ -28,7 +28,7 @@ the name of an executable located in
.\"-------------------------------------
.TP
.I binary arguments
-options and arguments, wich will be passed through to the
+options and arguments, which will be passed through to the
.IR binary .
.\"------------------------------------------------------------------------
.SH EXAMPLE
@@ -44,4 +44,4 @@ user\(aqs mailbox.
.\"------------------------------------------------------------------------
.SH SEE ALSO
.BR doveadm (1),
-.BR dovecot\-lda (1)
\ No newline at end of file
+.BR dovecot\-lda (1)
Description: lintian: reseting -> resetting
Author: A. Schulze
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: dovecot-2.2.32~rc1/src/director/director-connection.c
===================================================================
--- dovecot-2.2.32~rc1.orig/src/director/director-connection.c
+++ dovecot-2.2.32~rc1/src/director/director-connection.c
@@ -770,7 +770,7 @@ static bool director_cmd_director(struct
}
/* just forward this to the entire ring until it reaches back to
itself. some hosts may see this twice, but that's the only way to
- guarantee that it gets seen by everyone. reseting the host multiple
+ guarantee that it gets seen by everyone. resetting the host multiple
times may cause us to handle its commands multiple times, but the
commands can handle that. however, we need to also handle a
situation where the added director never comes back - we don't want
@@ -1469,7 +1469,7 @@ director_connection_sync_host(struct dir
timestamp);
return FALSE;
} else if (seq < host->last_sync_seq) {
- i_warning("Last SYNC seq for %s appears to be stale, reseting "
+ i_warning("Last SYNC seq for %s appears to be stale, resetting "
"(seq=%u, timestamp=%u -> seq=%u, timestamp=%u)",
host->name, host->last_sync_seq,
host->last_sync_timestamp, seq, timestamp);
