On Wed, Nov 02, 2016 at 05:31:28PM +0100, Christophe Fergeau wrote: > > > > > + if (client_head->flags != 0) { > > > + client_head->flags = 0; > > > + changed = true; > > > + } > > > > why testing flags change if is always 0 ? > > Yeah, same for surface_id above actually. Just mechanically changed > everything ;)
At first I changed the commit to exclude flags and surface_id from these checks, but on second though, I'd keep them the same way as the rest, this way if these can get changed to a different value outside of copy_rom, this code will still work as intended. Christophe -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161102/2b5b804f/attachment.sig>