On Thu, Nov 24, 2022 at 06:20:56PM +0800, Pin-yen Lin wrote:
> Register USB Type-C mode switches when the "mode-switch" property and
> relevant port are available in Device Tree. Configure the "lane_swap"
> state based on the entered alternate mode for a specific Type-C
> connector, which ends up updating the lane swap registers of the it6505
> chip.

...

>  config DRM_ITE_IT6505
>          tristate "ITE IT6505 DisplayPort bridge"
>          depends on OF
> +     depends on TYPEC || TYPEC=n
>       select DRM_DISPLAY_DP_HELPER
>       select DRM_DISPLAY_HDCP_HELPER
>       select DRM_DISPLAY_HELPER

Something went wrong with the indentation. Perhaps you need to fix it first.

...

>  #include <drm/drm_edid.h>
>  #include <drm/drm_print.h>
>  #include <drm/drm_probe_helper.h>
> +#include <drm/drm_of.h>

Make it ordered?

...

> +struct it6505_port_data {

> +     bool dp_connected;

Perhaps make it last?

> +     struct typec_mux_dev *typec_mux;
> +     struct it6505 *it6505;
> +};

...

> +static void it6505_typec_ports_update(struct it6505 *it6505)
> +{
> +     usleep_range(3000, 4000);
> +
> +     if (it6505->typec_ports[0].dp_connected && 
> it6505->typec_ports[1].dp_connected)
> +             /* Both ports available, do nothing to retain the current one. 
> */
> +             return;
> +     else if (it6505->typec_ports[0].dp_connected)
> +             it6505->lane_swap = false;
> +     else if (it6505->typec_ports[1].dp_connected)
> +             it6505->lane_swap = true;
> +
> +     usleep_range(3000, 4000);
> +}

As per previous patch comments.

Also, comment out these long sleeps. Why they are needed.

...

> +             int ret = pm_runtime_get_sync(dev);
> +
> +             /*
> +              * On system resume, mux_set can be triggered before
> +              * pm_runtime_force_resume re-enables runtime power management.

We refer to the functions as func().

> +              * Handling the error here to make sure the bridge is powered 
> on.
> +              */
> +             if (ret < 0)
> +                     it6505_poweron(it6505);

This seems needed a bit more of explanation, esp. why you leave PM runtime
reference count bumped up.

...

> +     num_lanes = drm_of_get_data_lanes_count(node, 0, 2);
> +     if (num_lanes <= 0) {
> +             dev_err(dev, "Error on getting data lanes count: %d\n",
> +                     num_lanes);
> +             return num_lanes;
> +     }
> +
> +     ret = of_property_read_u32_array(node, "data-lanes", dp_lanes, 
> num_lanes);
> +     if (ret) {
> +             dev_err(dev, "Failed to read the data-lanes variable: %d\n",
> +                     ret);
> +             return ret;
> +     }
> +
> +     for (i = 0; i < num_lanes; i++) {
> +             if (port_num != -1 && port_num != dp_lanes[i] / 2) {
> +                     dev_err(dev, "Invalid data lane numbers\n");
> +                     return -EINVAL;
> +             }

As per previous patch comments.

> +             port_num = dp_lanes[i] / 2;
> +     }

The above seems like tons of duplicating code that drivers need to implement.
Can we shrink that burden by adding some library functions?

-- 
With Best Regards,
Andy Shevchenko


Reply via email to