Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
---
 drivers/video/backlight/lm3630a_bl.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/backlight/lm3630a_bl.c 
b/drivers/video/backlight/lm3630a_bl.c
index a3412c936ca2..93fd6dbccc28 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -563,10 +563,9 @@ static int lm3630a_probe(struct i2c_client *client)
        /* pwm */
        if (pdata->pwm_ctrl != LM3630A_PWM_DISABLE) {
                pchip->pwmd = devm_pwm_get(pchip->dev, "lm3630a-pwm");
-               if (IS_ERR(pchip->pwmd)) {
-                       dev_err(&client->dev, "fail : get pwm device\n");
-                       return PTR_ERR(pchip->pwmd);
-               }
+               if (IS_ERR(pchip->pwmd))
+                       return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd),
+                                            "fail : get pwm device\n");
 
                pwm_init_state(pchip->pwmd, &pchip->pwmd_state);
        }

-- 
2.34.1

Reply via email to