Code can be simpler: return directly when devm_gpiod_get_optional()
failed.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
---
 drivers/video/backlight/lm3630a_bl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/backlight/lm3630a_bl.c 
b/drivers/video/backlight/lm3630a_bl.c
index 93fd6dbccc28..ac0a60e39e39 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -543,10 +543,8 @@ static int lm3630a_probe(struct i2c_client *client)
 
        pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable",
                                                GPIOD_OUT_HIGH);
-       if (IS_ERR(pchip->enable_gpio)) {
-               rval = PTR_ERR(pchip->enable_gpio);
-               return rval;
-       }
+       if (IS_ERR(pchip->enable_gpio))
+               return PTR_ERR(pchip->enable_gpio);
 
        /* chip initialize */
        rval = lm3630a_chip_init(pchip);

-- 
2.34.1

Reply via email to