On Thu, Jul 24, 2025 at 5:50 PM AngeloGioacchino Del Regno <angelogioacchino.delre...@collabora.com> wrote: > > Fix the pinctrl node names to adhere to the bindings, as the main > pin node is supposed to be named like "uart0-pins" and the pinmux > node named like "pins-bus". > > Signed-off-by: AngeloGioacchino Del Regno > <angelogioacchino.delre...@collabora.com>
Reviewed-by: Fei Shao <fs...@chromium.org> > --- > .../boot/dts/mediatek/pumpkin-common.dtsi | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > index a356db5fcc5f..805fb82138a8 100644 > --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi > @@ -198,8 +198,8 @@ &usb_phy { > }; > > &pio { > - gpio_keys_default: gpiodefault { > - pins_cmd_dat { > + gpio_keys_default: gpio-keys-pins { > + pins-cmd-dat { > pinmux = <MT8516_PIN_42_KPCOL0__FUNC_GPIO42>, > <MT8516_PIN_43_KPCOL1__FUNC_GPIO43>; > bias-pull-up; > @@ -207,7 +207,7 @@ pins_cmd_dat { > }; > }; > > - i2c0_pins_a: i2c0 { > + i2c0_pins_a: i2c0-pins { > pins1 { > pinmux = <MT8516_PIN_58_SDA0__FUNC_SDA0_0>, > <MT8516_PIN_59_SCL0__FUNC_SCL0_0>; > @@ -215,7 +215,7 @@ pins1 { > }; > }; > > - i2c2_pins_a: i2c2 { > + i2c2_pins_a: i2c2-pins { > pins1 { > pinmux = <MT8516_PIN_60_SDA2__FUNC_SDA2_0>, > <MT8516_PIN_61_SCL2__FUNC_SCL2_0>; > @@ -223,21 +223,21 @@ pins1 { > }; > }; > > - tca6416_pins: pinmux_tca6416_pins { > - gpio_mux_rst_n_pin { > + tca6416_pins: tca6416-pins { > + pins-mux-rstn { > pinmux = <MT8516_PIN_65_UTXD1__FUNC_GPIO65>; > output-high; > }; > > - gpio_mux_int_n_pin { > + pins-mux-intn { > pinmux = <MT8516_PIN_64_URXD1__FUNC_GPIO64>; > input-enable; > bias-pull-up; > }; > }; > > - ethernet_pins_default: ethernet { > - pins_ethernet { > + ethernet_pins_default: ethernet-pins { > + pins-eth { > pinmux = <MT8516_PIN_0_EINT0__FUNC_EXT_TXD0>, > <MT8516_PIN_1_EINT1__FUNC_EXT_TXD1>, > <MT8516_PIN_5_EINT5__FUNC_EXT_RXER>, > -- > 2.50.1 > >