On Tue, Sep 09, 2025 at 07:39:02PM +0300, Svyatoslav Ryhel wrote: > вт, 9 вер. 2025 р. о 19:26 Rob Herring <[email protected]> пише: > > > > On Sat, Sep 06, 2025 at 04:53:42PM +0300, Svyatoslav Ryhel wrote: > > > Document CSI HW block found in Tegra20 and Tegra30 SoC. > > > > > > Signed-off-by: Svyatoslav Ryhel <[email protected]> > > > --- > > > .../display/tegra/nvidia,tegra20-csi.yaml | 104 ++++++++++++++++ > > > .../display/tegra/nvidia,tegra30-csi.yaml | 115 ++++++++++++++++++ > > > 2 files changed, 219 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > create mode 100644 > > > Documentation/devicetree/bindings/display/tegra/nvidia,tegra30-csi.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > new file mode 100644 > > > index 000000000000..1a2858a5893c > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-csi.yaml > > > @@ -0,0 +1,104 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/tegra/nvidia,tegra20-csi.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NVIDIA Tegra20 CSI controller > > > + > > > +maintainers: > > > + - Svyatoslav Ryhel <[email protected]> > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - nvidia,tegra20-csi > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + avdd-dsi-csi-supply: > > > + description: DSI/CSI power supply. Must supply 1.2 V. > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > + "#nvidia,mipi-calibrate-cells": > > > + description: The number of cells in a MIPI calibration specifier. > > > + Should be 1. The single cell specifies an id of the pads that > > > + need to be calibrated for a given device. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + const: 1 > > > > This property goes in the provider. Is the parent node the provider? You > > don't really need any of it if it's all one block. > > > > Yes parent node is provides and channel is one of receivers, other one > is DSI node.
Please make that clear in the descriptions somewhere. > > > > + > > > + "#address-cells": > > > + const: 1 > > > + > > > + "#size-cells": > > > + const: 0 > > > + > > > +patternProperties: > > > + "^channel@[0-1]$": > > > + type: object > > > + description: channel 0 represents CSI-A and 1 represents CSI-B > > > + additionalProperties: false > > > + > > > + properties: > > > + reg: > > > + maxItems: 1 > > > > Instead: > > > > maximum: 1 > > > > > > > + > > > + nvidia,mipi-calibrate: > > > + description: Should contain a phandle and a specifier specifying > > > + which pads are used by this DSI output and need to be > > > + calibrated. 0 is for CSI-A, 1 is for CSI-B, 2 is for DSI. > > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > > > Is DSI applicable here? > > > > It is because CSI is calibration provider. I can move it up into > #nvidia,mipi-calibrate-cells which may be more appropriate place. Yes, as the provider defines the meaning of the cells (and they are opaque to the consumer). Rob
