On 12/09/2025 19:19, Daniel Almeida wrote: > This series adds basic Panthor tests. In particular, these are being > used to test both Panthor[0] and Tyr[1], i.e.: the new Rust GPU driver > that implements Panthor's uAPI (i.e.: panthor_drm.h). Most of the > initial tests were chosen in order to have something to test Tyr with, > but this series lays the groundwork so that more interesting tests can > be added to test more of Panthor itself. > > This work is being tested on a RockPi 5, featuring an rk3588 SoC and > Mali-G610 Valhall. > > Note that there's a few (less than five?) remaining checkpatch.pl > comments about long lines. IMHO there's no way to format them better so > I hope we can live with this. > > [0]: > https://patchwork.freedesktop.org/patch/msgid/[email protected] > [1]: https://lore.kernel.org/dri-devel/[email protected]/ > > Changes from v1: > - Rebased on top of the latest master > - Squashed patch 3 from v1 into patch 2. > - Switched to /* */ comments in headers > - Initialized padding fields to 0 as applicable in group_destroy and > vm_destroy > - Removed wrong assert(gpu_rev != 0) > - Changed indentation to use tabs > - Rework igt_panthor_mmap_bo to take an offset (so we don't call the > mmap_offset ioctl twice) > - Added igt_describe and docs to the functions igt_panthor.c > - Linked to the driver in the cover letter and patch 1. > - Improved the commit message for patch 1. > Link to v1: > https://lore.kernel.org/dri-devel/[email protected]/
Looks good to me, and all the tests now pass (using Panthor) on my Rock5B. Tested-by: Steven Price <[email protected]> Thanks, Steve > > Daniel Almeida (3): > lib: add support for opening Panthor devices > panthor: add initial infrastructure > tests/panthor: add panthor tests > > lib/drmtest.c | 1 + > lib/drmtest.h | 1 + > lib/igt_panthor.c | 229 ++++++++++++++++++++++++++++ > lib/igt_panthor.h | 30 ++++ > lib/meson.build | 1 + > meson.build | 8 + > tests/meson.build | 2 + > tests/panthor/meson.build | 15 ++ > tests/panthor/panthor_gem.c | 66 ++++++++ > tests/panthor/panthor_group.c | 276 ++++++++++++++++++++++++++++++++++ > tests/panthor/panthor_query.c | 25 +++ > tests/panthor/panthor_vm.c | 80 ++++++++++ > 12 files changed, 734 insertions(+) > create mode 100644 lib/igt_panthor.c > create mode 100644 lib/igt_panthor.h > create mode 100644 tests/panthor/meson.build > create mode 100644 tests/panthor/panthor_gem.c > create mode 100644 tests/panthor/panthor_group.c > create mode 100644 tests/panthor/panthor_query.c > create mode 100644 tests/panthor/panthor_vm.c >
