On 10/1/25 19:19, Albin Babu Varghese wrote:
Hi Helge, Thanks for the review.
I wonder if the image.height value should be capped in this case,
instead of not rendering any chars at all?
Something like (untested!):
+ if (image.dy >= info->var.yres)
+ return;
+ image.height = min(image.height, info->var.yres - image.dy);
This looks like a better implementation than what I had.
I just added comments - not sure if mine was better.,
I thought it might be better to skip the entire row instead of
rendering partially.
Do you know if this affects the selection?
If so, would modifying (reducing/shortening) the selection maybe fix it?
I’m still new to this subsystem, so thanks for pointing this out.
I’ll test the suggested changes and send a v2.
Thanks for testing and checking!
Helge
