On 2025-12-26 18:43:03, Linus Walleij wrote: > On Fri, Dec 26, 2025 at 3:16 PM Marijn Suijten > <[email protected]> wrote: > > On 2025-12-26 14:21:37, Linus Walleij wrote: > > > > The sofef00 driver tell us exactly what this sequence is: > > > > > > #define sofef00_test_key_on_lvl2(ctx) \ > > > mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0x5a, 0x5a) > > > #define sofef00_test_key_off_lvl2(ctx) \ > > > mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0xa5, 0xa5) > > > > > > I would just rename these two to sofef01_test_key_on/off_lvl2() > > > and use the same helpers in this driver to follow the sofef00 pattern. > > > > Right, yes. I think I already brought this up in V1, that some existing > > Samsung drivers call this (the 0xf0 part) the MCS PASSWORD, others call it > > the > > LEVEL_2_KEY or USER_KEY or ACCESSPROT. > > Actually all of the samsung s6e panels are suspected to be s0fef0/1
Just noting the first 0 is actually the letter o. > display controller variants, which you see if you look inside > panel-samsung-s6e*, for example panel-samsung-s6e3fc2x01.c has this: ... > I think the s0fef0/1 drivers and all the panel-samsung-s6e* drivers > should probably be unified a bit maybe we can just create a > local s0fef.h file with the above for all these drivers to use? > > (If someone has actual datasheets for s0fef0/1 that would be great.) If we know exactly what the commands are, and have their arguments documented, it'd be nice to have these as constants and functions in a global reusable header, but it does require being absolutely certain on their meaning and equivalence. - Marijn
