On 1/4/26 2:44 PM, Ayushi Makhija wrote:
> Add anx7625 DSI to DP bridge device node.
>
> Signed-off-by: Ayushi Makhija <[email protected]>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
> ---
[...]
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 177 ++++++++++++++++++++++
> 1 file changed, 177 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 4a8ac26846c6..8d324bf85e4d 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -24,6 +24,69 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + vreg_12p0: regulator-vreg-12p0 {
> + compatible = "regulator-fixed";
> + regulator-name = "VREG_12P0";
> +
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vreg_5p0: regulator-vreg-5p0 {
> + compatible = "regulator-fixed";
> + regulator-name = "VREG_5P0";
> +
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> +
> + vin-supply = <&vreg_12p0>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + vreg_1p8: regulator-vreg-1p8 {
The regulator entries seem to be sorted in a "wrong" order (alphabetical
wrt node name is preferred). Please note that you don't need to strictly
have the definition above a reference like you do in C.
[...]
> + port@0 {
> + reg = <0>;
> + dsi2dp_bridge_in: endpoint {
> +
> + remote-endpoint =
> <&mdss_dsi0_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + dsi2dp_bridge_out: endpoint {
A '\n' after both 'reg's would be perfect
Konrad
