On Mon, Jan 19, 2026 at 02:13:48PM +0100, Danilo Krummrich wrote: > On Mon Jan 19, 2026 at 1:54 PM CET, Daniel Almeida wrote: > >> On 19 Jan 2026, at 09:35, Alice Ryhl <[email protected]> wrote: > >> I think that if you still want an API where you just call enable/disable > >> directly on it with no protection against unbalanced calls, then that > >> should be the special API. Probably called RawClk and functions marked > >> unsafe. Unbalanced calls seem really dangerous and use should not be > >> encouraged. > > +1; and unless there is a use-case that requires otherwise, it should not even > be possible to do this at all -- at least for driver code.
I mean, it's great, it's safe, etc. but it's also suboptimal from a PM perspective on many platforms. It's totally fine to provide nice, safe, ergonomic wrappers for the drivers that don't care (or can't, really), but treating a legitimate optimisation as something we should consider impossible to do is just weird to me. > > I think we should discourage RawClk if at all possible. But if the consensus > > is that we *really* need this easily-abused thing, I can provide a > > follow-up. > > I think we should only do this if there are use-case with no alternative, so > far > there haven't been any AFAIK. I don't really care about which alternative we come up with, but look at devm_regmap_init_mmio_clk for example. It is a valid use-case that already exists today, and has had for more than a decade at this point. Maxime
signature.asc
Description: PGP signature
