In case the channel0 is unavailable and bailing out from free_child is
needed when we fail to add a DRM bridge for the available channel1,
pointer pc->ch[0] in the bailout path would be NULL and it would be
dereferenced as pc->ch[0]->bridge.next_bridge.  Fix this by checking
pc->ch[0] before dereferencing it.

Fixes: ae754f049ce1 ("drm/bridge: imx8qxp-pixel-combiner: get/put the next 
bridge")
Fixes: 99764593528f ("drm/bridge: imx8qxp-pixel-combiner: convert to 
devm_drm_bridge_alloc() API")
Signed-off-by: Liu Ying <[email protected]>
---
 drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c 
b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
index 00dcd273d8ab..27ad66f240cf 100644
--- a/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
+++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c
@@ -345,7 +345,7 @@ static int imx8qxp_pc_bridge_probe(struct platform_device 
*pdev)
 free_child:
        of_node_put(child);
 
-       if (i == 1 && pc->ch[0]->bridge.next_bridge)
+       if (i == 1 && pc->ch[0] && pc->ch[0]->bridge.next_bridge)
                drm_bridge_remove(&pc->ch[0]->bridge);
 
        pm_runtime_disable(dev);

-- 
2.43.0

Reply via email to