On Fri, Jan 23, 2026 at 05:22:16PM +0800, Liu Ying wrote:
> Pointer bridge->driver_private in imx8qxp_pxl2dpi_bridge_destroy()
> is NULL when imx8qxp_pxl2dpi_bridge_probe() returns error, because
> the pointer is initialized only when imx8qxp_pxl2dpi_bridge_probe()
> returns 0. The NULL pointer would be set to pointer p2d and then
> NULL pointer p2d would be dereferenced. Fix this by returning early
> from imx8qxp_pxl2dpi_bridge_destroy() if !p2d is true.
>
> Fixes: 900699ba830f ("drm/bridge: imx8qxp-pxl2dpi: get/put the companion
> bridge")
> Signed-off-by: Liu Ying <[email protected]>
> ---
Reviewed-by: Frank Li <[email protected]>
> drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> index f0814702b641..9dc2b3d2ecef 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
> @@ -67,6 +67,9 @@ static void imx8qxp_pxl2dpi_bridge_destroy(struct
> drm_bridge *bridge)
> {
> struct imx8qxp_pxl2dpi *p2d = bridge->driver_private;
>
> + if (!p2d)
> + return;
> +
> drm_bridge_put(p2d->companion);
> }
>
>
> --
> 2.43.0
>
