On 24/02/2026 11:43, Danilo Krummrich wrote:
(Cc: Tvrtko)
On Tue Feb 24, 2026 at 12:03 PM CET, Maxime Ripard wrote:
Some DRM tests cross the 1s execution time threshold that defines a test
as slow. Let's flag them as such.
<snip>
static struct kunit_case drm_sched_credits_tests[] = {
- KUNIT_CASE(drm_sched_test_credits),
+ KUNIT_CASE_SLOW(drm_sched_test_credits),
Hm..I don't think this test should be that slow.
Looking at the code, I see intentional timeouts through:
done = drm_mock_sched_job_wait_scheduled(job[1], HZ);
KUNIT_ASSERT_FALSE(test, done);
Since the timeout is in jiffies, this should be always 1s, which seems a bit
overkill.
Maybe we should just change this to msecs_to_jiffies(200), which should still be
plenty and keep the test below 500ms.
Right, 200ms should be more than plenty. It is only making sure the
scheduler is not oversubscribing the configured credits, and the delay
needed to be sure about that is around two worker wake up to run cycles.
Regards,
Tvrtko
