On Thu, 2026-02-26 at 12:42 +0000, Tvrtko Ursulin wrote:
>
> On 26/02/2026 10:56, Maxime Ripard wrote:
>
>
[…]
> > > > {}
> > > > };
> > > > static struct kunit_suite drm_sched_priority = {
> > > > .name = "drm_sched_basic_priority_tests",
> > > > @@ -544,11 +544,11 @@ static void drm_sched_test_credits(struct kunit
> > > > *test)
> > > > drm_mock_sched_entity_free(entity);
> > > > drm_mock_sched_fini(sched);
> > > > }
> > > > static struct kunit_case drm_sched_credits_tests[] = {
> > > > - KUNIT_CASE(drm_sched_test_credits),
> > > > + KUNIT_CASE_SLOW(drm_sched_test_credits),
> > >
> > > Same really.
> > >
> > > Anyway, the scheduler parts LGTM and I can follow up trying to optimise
> > > these two later.
> > >
> > > For the scheduler:
> > >
> > > Reviewed-by: Tvrtko Ursulin <[email protected]>
> >
> > Thanks!
>
> I have a patch already which makes those (and one more) test cases
> faster, but I will wait sending it until you merge this one.
And why would we want to flag a test as slow just to immediately
afterwards make it faster?
Would it not be wiser to drop Maxime's change?
P.
