Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/panthor: diagnostic info loss in GPU ID log --
commit 18159d0a7677f6cb80f96ffd38fefa04603df0e5 Author: Karunika Choo <[email protected]> drm/panthor: Parse and store GPU_ID fields Prepare for Mali v15 by expanding GPU_ID to 64 bits and caching fields during initialization. > diff --git a/drivers/gpu/drm/panthor/panthor_hw.c > b/drivers/gpu/drm/panthor/panthor_hw.c > index 4c96573b649a1..2143e57d48106 100644 > --- a/drivers/gpu/drm/panthor/panthor_hw.c > +++ b/drivers/gpu/drm/panthor/panthor_hw.c > @@ -245,13 +245,13 @@ static int panthor_hw_info_init(struct panthor_device > *ptdev) > if (ret) > return ret; > > - major = GPU_VER_MAJOR(ptdev->gpu_info.gpu_id); > - minor = GPU_VER_MINOR(ptdev->gpu_info.gpu_id); > - status = GPU_VER_STATUS(ptdev->gpu_info.gpu_id); > + major = ptdev->gpu_id.ver_major; > + minor = ptdev->gpu_id.ver_minor; > + status = ptdev->gpu_id.ver_status; > > drm_info(&ptdev->base, > "%s id 0x%x major 0x%x minor 0x%x status 0x%x", > - get_gpu_model_name(ptdev), ptdev->gpu_info.gpu_id >> 16, > + get_gpu_model_name(ptdev), ptdev->gpu_id.prod_major, > major, minor, status); [Severity: Low] Does this unintentionally drop the architecture major, minor, and revision values from the printed GPU ID? Since ptdev->gpu_info.gpu_id >> 16 contains more than just the product major, replacing it with only ptdev->gpu_id.prod_major causes an information loss in the boot logs. For unknown GPUs, this makes it harder to identify the unsupported hardware because it will log as id 0x2 instead of id 0xa002 (if arch=10, prod=2). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
