Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/connector: missing kernel-doc header on enum vrr_display_mode --
commit da4673cb9da04a6d510c119f2c09b6e0b6e956b2 Author: Nicolas Frattaroli <[email protected]> drm/connector: add vrr_display_mode connector property This commit introduces the vrr_display_mode connector enum property and its associated connector state field so userspace can explicitly control whether a VRR-capable display operates in Game or Off mode regardless of CRTC state. > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 2ee7c59329aae..8699f35cafcba 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -809,6 +809,15 @@ enum drm_bus_flags { > DRM_BUS_FLAG_SHARP_SIGNALS = BIT(8), > }; > > +enum vrr_display_mode { > + /** @VRR_DISPLAY_MODE_GAME: Set the display to VRR "Game" mode */ > + VRR_DISPLAY_MODE_GAME = 0, > + /** @VRR_DISPLAY_MODE_OFF: Turn off VRR on the display */ > + VRR_DISPLAY_MODE_OFF, > + /** @VRR_DISPLAY_MODE_COUNT: Sentinel, not a valid mode, keep last */ > + VRR_DISPLAY_MODE_COUNT > +}; [Severity: Low] enum vrr_display_mode documents its enumerators with inline kernel-doc comments and is cross-referenced as &enum vrr_display_mode from struct drm_connector_state and struct drm_connector, but it does not have an opening kernel-doc comment block above the enum declaration. Because kernel-doc only enters declaration parsing after encountering a standalone /** header line, scripts/kernel-doc skips enum vrr_display_mode and its inline member descriptions when processing include/drm/drm_connector.h. Should a /** enum vrr_display_mode - ... */ kernel-doc header block be added above enum vrr_display_mode? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
