Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] drm/connector: false VRR capability in drm_display_info_is_vrr_capable() --
commit 2c6b233292887595c2334a70a795f9f766983787 Author: Nicolas Frattaroli <[email protected]> drm/connector: Add drm_display_info_is_vrr_capable This commit adds drm_display_info_is_vrr_capable() to check whether a sink described by struct drm_display_info supports variable refresh rate signals. It checks info->hdmi.vrr_cap.supported for HDMI sinks and info->monitor_range.min_vfreq > 0 for other displays. > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 65c14b6e47a6f..a44afba8c5ff2 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1378,6 +1378,25 @@ int drm_display_info_set_bus_formats(struct > drm_display_info *info, > } > EXPORT_SYMBOL(drm_display_info_set_bus_formats); > > +/** > + * drm_display_info_is_vrr_capable - Check whether sink is VRR capable > + * @info: pointer to a &struct drm_display_info representing the sink > + * > + * Check whether the sink supports variable refresh rate signals. > + * > + * Returns: > + * - true if variable refresh rate is supported by the sink > + * - false otherwise > + */ > +bool drm_display_info_is_vrr_capable(const struct drm_display_info *info) > +{ > + if (info->is_hdmi) > + return info->hdmi.vrr_cap.supported; > + > + return info->monitor_range.min_vfreq > 0; > +} [Severity: Medium] As reported by Sashiko on RFC [1], in drm_display_info_is_vrr_capable() in drivers/gpu/drm/drm_connector.c, can returning info->monitor_range.min_vfreq > 0 for any sink where info->is_hdmi is false falsely report VRR support on non-VRR displays? In drivers/gpu/drm/drm_edid.c, drm_get_monitor_range() -> get_monitor_range() populates info->monitor_range from any standard EDID 1.4+ continuous-frequency (DRM_EDID_FEATURE_CONTINUOUS_FREQ) Display Range Limits descriptor (tag 0xFD) with DRM_EDID_RANGE_LIMITS_ONLY_FLAG: drivers/gpu/drm/drm_edid.c:get_monitor_range() { ... monitor_range->min_vfreq = range->min_vfreq; monitor_range->max_vfreq = range->max_vfreq; ... } Existing VRR checks in drivers/gpu/drm/i915/display/intel_vrr.c and drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c do not rely on min_vfreq > 0 alone. Both check for DPCD MSA timing ignore support and require a valid range span larger than 10 Hz: drivers/gpu/drm/i915/display/intel_vrr.c:intel_vrr_is_capable() { ... if (!info->monitor_range.min_vfreq || !info->monitor_range.max_vfreq || info->monitor_range.min_vfreq > info->monitor_range.max_vfreq) return false; return info->monitor_range.max_vfreq - info->monitor_range.min_vfreq > 10; } drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c:amdgpu_dm_update_freesync_caps() { ... if (amdgpu_dm_connector->dc_link && amdgpu_dm_connector->dc_link->dpcd_caps.allow_invalid_MSA_timing_param && amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10) freesync_capable = true; ... } Without checking DPCD capabilities (which are not stored in struct drm_display_info) or validating max_vfreq and max_vfreq - min_vfreq > 10, a standard non-VRR monitor with a 50-60 Hz range descriptor, a malformed range descriptor, or a DVI/non-VSDB sink attached to an HDMI connector (where info->is_hdmi is false) will cause drm_display_info_is_vrr_capable() to return true. On HDMI encoders using this helper, that advertises vrr_capable as true even though HDMI VRR validation later rejects VRR commits with -EOPNOTSUPP. [1] https://lore.kernel.org/r/[email protected] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
