Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/atomic: wrong Fixes commit in drm_atomic_private_obj_init()
  fix
--

commit a21244827cf8a5badb67ea5cb6c337990a26e370
Author: Maxime Ripard <[email protected]>

> drm/atomic: Fix private obj error handling
>
> drm_atomic_private_obj_init() initializes the modeset lock and adds the
> object to the privobj_list before calling atomic_create_state().
>
> However, if atomic_create_state() fails, the function returns the error
> directly without removing the object from the list or cleaning up the
> lock. This leaves a dangling entry in privobj_list and a leaked lock.
>
> Fix this by unwinding both operations in an error path.
>
> Fixes: b962a12050a3 ("drm/atomic: integrate modeset lock with private 
> objects")
> Suggested-by: Laurent Pinchart <[email protected]>
> Reviewed-by: Maarten Lankhorst <[email protected]>
> Signed-off-by: Maxime Ripard <[email protected]>

[Severity: Low]
In b962a12050a3 ("drm/atomic: integrate modeset lock with private objects"),
drm_atomic_private_obj_init() returned void, took a caller-allocated state
pointer, and had no error path.  The atomic_create_state() call and its
uncleaned error return were added by 47b5ac7daa46 ("drm/atomic: Add new
atomic_create_state callback to drm_private_obj").  Should the Fixes tag be:

  Fixes: 47b5ac7daa46 ("drm/atomic: Add new atomic_create_state callback to 
drm_private_obj")

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=6

Reply via email to