Hi Philipp, On Fri, Nov 06, 2026, Philipp Zabel wrote: > You can just use devm_reset_control_get_optional_exclusive() > unconditionally. Device tree validation makes sure the required reset > will be specified.
Thanks for the review. I have switched to devm_reset_control_get_optional_exclusive() unconditionally. > reset_control_reset() already checks that ptdev->reset_control != NULL, > so the first check is superfluous. I have removed the NULL check and kept the !panthor_device_is_initialized() condition. > + bool needs_external_reset; > > Not needed. I have removed this field from the Sky1 SoC data. I have tested these changes locally and they work. I plan to include these changes in v2 after waiting for any other review comments. Best regards, Cunyuan 本邮件及其附件包含CIX公司的保密信息,受法律保护,仅供本邮件指定的收件人查阅。严禁任何未经授权的使用、传播、分发或复制本邮件及其任何内容。此限制适用于指定收件人以外的所有人员,包括未经明确授权处理此类信息的CIX公司员工或代理人。若您误收本邮件,请立即通知发件人,并永久删除邮件及所有附件。互联网传输无法保证及时性、安全性、完整性和无病毒性,CIX公司对任何传输错误或遗漏概不承担责任。
