Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: gpu: arm,mali-valhall-csf: unwieldy per-compatible conditionals --
commit f3e7a046ab621a6ec3308f5290d9455780be0bec Author: Cunyuan Liu <[email protected]> dt-bindings: gpu: Add CIX Sky1 Mali support This commit adds the CIX Sky1 Mali compatible string, resource constraints, and a Device Tree example to the Arm Mali Valhall CSF GPU binding schema. > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > index 8eccd4338a2b2..a93acc6d91ec8 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > @@ -18,6 +18,7 @@ properties: > oneOf: > - items: > - enum: > + - cix,sky1-mali > - mediatek,mt8196-mali > - nxp,imx95-mali # G310 > - rockchip,rk3588-mali > @@ -51,6 +52,9 @@ properties: > - stacks > - const: stacks > > + resets: > + maxItems: 1 > + > nvmem-cells: > items: > - description: bitmask of functional shader cores > @@ -146,6 +150,34 @@ allOf: > - nvmem-cells > - nvmem-cell-names > - power-domains > + - if: > + properties: > + compatible: > + contains: > + const: cix,sky1-mali > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + clock-names: > + items: > + - const: core > + - const: stacks > + power-domains: > + maxItems: 1 > + power-domain-names: false > + mali-supply: false > + sram-supply: false > + nvmem-cells: false > + nvmem-cell-names: false > + required: > + - clock-names > + - resets > + - power-domains > + else: > + properties: > + resets: false [Severity: Low] With each variant adding another per-compatible if-then-else block to disable properties used only by other SoCs (and setting resets: false for all other variants), the conditionals in arm,mali-valhall-csf.yaml are becoming unwieldy. Should this binding be split into separate schema documents rather than piling on more variant-specific conditionals here? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
