Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: arm: fsl: standalone SoM compatible entry for byteengine-imx93 --
commit 16c85ae9ce2da615e1c5f80c4ecb02932e8f9200 Author: Frank Obergfell <[email protected]> dt-bindings: arm: fsl: Add byteENGINE i.MX93 platforms This commit adds the bytesatwork vendor prefix and documents the compatible strings for the byteENGINE i.MX93 System on Module and byteDEVKIT carrier board. > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > b/Documentation/devicetree/bindings/arm/fsl.yaml > index c8290a83205b6..d342930981d2a 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1555,6 +1555,18 @@ properties: > - fsl,imx93-wireless-frdm # i.MX93 and IW610G WLCSP (Wi-Fi + > BLE + 802.15.4) SiP FRDM Board > - const: fsl,imx93 > > + - description: i.MX93 boards with bytesatwork byteENGINE and bytedevkit > + items: > + - enum: > + - bytesatwork,bytedevkit-imx93 > + - const: bytesatwork,byteengine-imx93 > + - const: fsl,imx93 > + > + - description: i.MX93 boards with bytesatwork byteENGINE OSM Modules > + items: > + - const: bytesatwork,byteengine-imx93 > + - const: fsl,imx93 [Severity: Low] Should this standalone entry for bytesatwork,byteengine-imx93 be dropped? The byteENGINE i.MX93 is an OSM System-on-Module (represented by imx93-byteengine.dtsi) that cannot boot without a carrier board, and its compatible is already covered by the bytesatwork,bytedevkit-imx93 board entry above. Having a separate SoM-only entry allows root nodes without a board compatible to pass schema validation. Also, the commit message refers to "the byteENGINE carrier board" instead of the byteDEVKIT carrier board. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
