Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] dt-bindings: ilitek,ili9806e: non-specific youritech,ili9806e compatible - [Low] dt-bindings: ilitek,ili9806e: incomplete commit message for panel and vendor --
commit f808e27a7a6d1d461157c23c896bc2773caf8de9 Author: Frank Obergfell <[email protected]> > dt-bindings: display: panel: ilitek,ili9806e: Add Youritech ILI9806E > > Add youritech panel as a compatible > > Signed-off-by: Frank Obergfell <[email protected]> [Severity: Low] This isn't a bug, but the commit message omits any description of the panel hardware (such as the panel model, resolution, physical dimensions, and whether it uses MIPI-DSI or SPI) and does not mention the new youritech vendor prefix added to vendor-prefixes.yaml. > diff --git > a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > index 2080d9e0ffac4..6f29ddc1fd090 100644 > --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > @@ -19,6 +19,7 @@ properties: > - densitron,dmt028vghmcmi-1d > - ortustech,com35h3p70ulc > - rocktech,rk050hr345-ct106a > + - youritech,ili9806e > - const: ilitek,ili9806e [Severity: Medium] Should the compatible string use the specific Youritech panel part number rather than repeating the ili9806e controller IC name? In this binding, ilitek,ili9806e already identifies the display controller IC as the fallback compatible, while the first entry identifies the panel model. Using youritech,ili9806e makes it impossible to distinguish between different Youritech panels built around the ILI9806E that have different resolutions, physical dimensions, bus interfaces, or panel-specific initialization sequences. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
