Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/rockchip: vop2: missing Fixes trailer for commit 4f537776340d --
commit a8803c2d42085266d5dfa3113cf2bcad402ebf13 Author: Arun Iyengar <[email protected]> > drm/rockchip: vop2: Keep the other LUT_PORT_SEL fields on gamma LUT updates > > On RK3588 the gamma LUT of a video port is written through a window that > GAMMA_AHB_WRITE_SEL in SYS_CTRL_LUT_PORT_SEL selects. The register also > holds the dclk source selection of video ports 0 and 2 and the enable of > the video port 0/1 merge for modes wider than 4096 pixels, which writing > the whole register clears. > > Only update the write select field. > > Signed-off-by: Arun Iyengar <[email protected]> [Severity: Low] This fixes the full-register write to RK3568_LUT_PORT_SEL in vop2_crtc_atomic_set_gamma_seamless(). Should this include: Fixes: 4f537776340d ("rockchip/drm: vop2: add support for gamma LUT") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=7
