Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/rockchip: missing Fixes trailer for vop2_find_start_mixer_id_for_vp() --
commit bef29062242358932c819e26dffcbfccfee3a800 Author: Arun Iyengar <[email protected]> > drm/rockchip: vop2: Find the first mixer of a video port with Esmart3 too > > vop2_find_start_mixer_id_for_vp() looks for the first layer that holds a > window of the video port, but for_each_set_bit() takes the number of bits > to search, and ROCKCHIP_VOP2_ESMART3 is the highest window id, so Esmart3 > is never found. A video port whose bottom layer shows Esmart3 then starts > its alpha setup at the mixer of a higher layer, or, if Esmart3 is its > only window, past all layers, and programs mixers of other video ports. > > Search all window ids. > > Signed-off-by: Arun Iyengar <[email protected]> [Severity: Low] This fixes the window bitmask search bound in vop2_find_start_mixer_id_for_vp(). Should this include: Fixes: d3fe9aa49585 ("drm/rockchip: vop2: Use OVL_LAYER_SEL configuration instead of use win_mask calculate used layers") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=6
