Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/panthor: commit message does not explain why GPU_FEATURES_NX is renamed --
commit b271181b3f70a8fceddc935ef5d82c1ab9eb1aa8 Author: Karunika Choo <[email protected]> > drm/panthor: Rename neural accelerator feature macro to NX > > Rename GPU_FEATURES_NEURAL_ENGINE to GPU_FEATURES_NX. > Update the panthor_hw helper to use the new name. > > Signed-off-by: Karunika Choo <[email protected]> [Severity: Low] This isn't a bug, but the commit message only restates the code change without explaining why GPU_FEATURES_NEURAL_ENGINE is renamed to GPU_FEATURES_NX while panthor_hw_has_neural() and the PWR_NEURAL_* definitions keep the neural naming. Could the commit message explain the rationale for the new name (for example, matching the hardware register specification)? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
