Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/panthor: undocumented gpu-supply in panthor_system_regulator_init() --
commit 7d8058a58397fcb291163cb1ac726e2a1ba1d037 Author: Karunika Choo <[email protected]> drm/panthor: Add AM_SYSTEM platform driver This commit adds the AM_SYSTEM platform driver for Arm Mali 5th Gen AM GPUs to manage shared clock and regulator resources and perform the initial GPU reset sequence during probe. > diff --git a/drivers/gpu/drm/panthor/system/panthor_system_drv.c > b/drivers/gpu/drm/panthor/system/panthor_system_drv.c > new file mode 100644 > index 0000000000000..e70dba4058f38 > --- /dev/null > +++ b/drivers/gpu/drm/panthor/system/panthor_system_drv.c > @@ -0,0 +1,344 @@ [ ... ] > +static int panthor_system_regulator_init(struct panthor_system *sdev) > +{ > + struct regulator *regulator = NULL; > + int ret; > + > + regulator = devm_regulator_get_optional(sdev->dev, "gpu"); > + if (IS_ERR(regulator)) { > + ret = PTR_ERR(regulator); > + > + /* Regulator not found. Exit */ > + if (ret == -ENODEV) > + return 0; > + > + return dev_err_probe(sdev->dev, ret, "Failed to get > gpu-supply"); > + } [Severity: Low] Should gpu-supply be documented in Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-system.yaml? That schema sets additionalProperties: false without listing gpu-supply, so any arm,mali-gen5-am-system device tree node providing the regulator expected here will fail dtbs_check validation. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=12
