Fixes for the RK3588 VOP2 found while bringing up HDMI and DisplayPort on an Orange Pi 5 (RK3588S).
Tested on an Orange Pi 5 with an HDMI 2.1 TV and a DisplayPort monitor, pictures judged with a camera, v7.3 based kernel: VP_CLK_CTRL reads back without the garbage divider; the HDMI controller sees the sync polarities of +/+ and mixed modes; HDMI from 148.5 to 1188 MHz (TMDS and FRL) and DP show a correct picture; RGB565 on the Cluster windows scans out without YTR; NV12 in two GEM objects and an AFBC overlay at x=1001 show correctly. Not tested: -HSync/-VSync modes (none in the TV's list), BGR565, HDMI1, eDP, MIPI DSI and DPI (no hardware). Developed with Claude (Anthropic), which wrote the code and the commit messages. I reviewed every change. Signed-off-by: Arun Iyengar <[email protected]> --- Changes in v3: - Dropped v2 patch 5, which balanced the windows of a video port across both AXI ports: the TRM doesn't allow one port's layers on AXI0 and AXI1 (Chaoyi Chen). He pointed to the VP merge series for that case [1]. - Patch 1: dropped the comment (Chaoyi Chen). - Patch 2: no common initialisation; every interface sets the dividers it doesn't use to 1, and an unused dclk_out is no longer kept at the dclk_core rate (Damon Ding). - Patch 3: commit message corrected (Damon Ding); Reviewed-by added (Chaoyi Chen, Damon Ding); Cc Cristian Ciocaltea. - New patch 4: the HDMI vsync and hsync polarity bits were swapped. - Patch 5: YTR is only accepted for the 8 bit RGB formats, as the TRM says (Chaoyi Chen); comment dropped; new subject. - Dropped v2 patch 6, which reported POST_BUF_EMPTY at most once per frame: it hides an underflow instead of fixing its cause (Damon Ding). - Patch 6: Reviewed-by added (Chaoyi Chen, Damon Ding). - Patch 7: Reviewed-by added (Damon Ding). - Shorter commit messages and comments, no code change otherwise. - [1] https://lore.kernel.org/all/[email protected]/ - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - New patch 1: UV plane address from fb->obj[1] (Sashiko). - Mixer search: bounded by the new ROCKCHIP_VOP2_MAX_LAYER_ID (Chaoyi Chen); Fixes: tag (Sashiko). - LUT_PORT_SEL: Fixes: tag (Sashiko), Reviewed-by (Chaoyi Chen). - AFBC offsets: x offset modulo the superblock width, 32 with AFBC_FORMAT_MOD_BLOCK_SIZE_32x8 (Sashiko); Fixes: tag (Sashiko). - Cc Piotr Zalewski (author of the commit the LUT_PORT_SEL patch fixes). - Link to v1: https://patch.msgid.link/[email protected] --- Arun Iyengar (8): drm/rockchip: vop2: Take the UV plane address from the second GEM object drm/rockchip: vop2: Don't use uninitialised dividers on RK3588 drm/rockchip: vop2: Fix the HDMI sync polarity on RK3588 drm/rockchip: vop2: Fix the HDMI sync polarity bit order on RK3588 drm/rockchip: vop2: Only accept AFBC YTR for 8 bit RGB on RK3588 drm/rockchip: vop2: Find the first mixer of a video port with Esmart3 too drm/rockchip: vop2: Keep the other LUT_PORT_SEL fields on gamma LUT updates drm/rockchip: vop2: Fix the AFBC offsets of a source that starts inside a superblock drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 23 +++++++++++++++-------- drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 1 + drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 17 +++++++++++++---- 3 files changed, 29 insertions(+), 12 deletions(-) --- base-commit: 8deaade4a5a4ff635df91e246e42139ab2b33f6d change-id: 20261110-vop2-fixes-fa45142799c1 Best regards, -- Arun Iyengar <[email protected]>
