Hi, > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Low] drm/bridge: analogix_dp: inaccurate RK3288 PHY comment in > analogix_dp_probe()
> [Severity: Low] > Are this comment and the commit message accurate about RK3288? > > In arch/arm/boot/dts/rockchip/rk3288.dtsi and > Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml, > the RK3288 eDP node defines phys = <&edp_phy> and phy-names = "dp" for its > rockchip,rk3288-dp-phy device, which drivers/phy/rockchip/phy-rockchip-dp.c > programs via GRF_SOC_CON12 when phy_power_on() and phy_power_off() are > called on dp->phy. This is indeed inaccurate. Good catch. I will remove it in v5. Do you have any opinions on this issue, Damon? > RK3399 and RK3568 are the variants that omit the phys property and configure > the built-in PHY directly through the controller MMIO registers rather than > through a separate PHY device or GRF. Yes, you're right. RK3399 doesn't configure PHY through GRF; MMIO registers are the correct way. (RK3568 eDP is not supported in mainline yet.) I'll send a v5 with the comment removed and the commit message reworded. Thanks, Jun
