Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/bridge: analogix_dp: inaccurate RK3288 PHY comment in analogix_dp_probe() --
commit 720fa3eab5052c038874ca588f7e1541886e6915 Author: Jun Yan <[email protected]> drm/bridge: analogix_dp: use devm_phy_optional_get() for the DP PHY This commit replaces devm_phy_get() and its open-coded error handling with devm_phy_optional_get() in analogix_dp_probe() when acquiring the optional DP PHY. > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index 8bb4c48aa3b48..09171c6605d0b 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1427,21 +1427,13 @@ analogix_dp_probe(struct device *dev, struct > analogix_dp_plat_data *plat_data) > if (ret) > return ERR_PTR(ret); > > - dp->phy = devm_phy_get(dp->dev, "dp"); > - if (IS_ERR(dp->phy)) { > - dev_err(dp->dev, "no DP phy configured\n"); > - ret = PTR_ERR(dp->phy); > - if (ret) { > - /* > - * phy itself is not enabled, so we can move forward > - * assigning NULL to phy pointer. > - */ > - if (ret == -ENOSYS || ret == -ENODEV) > - dp->phy = NULL; > - else > - return ERR_PTR(ret); > - } > - } > + /* > + * RK3288/RK3399 use Analogix DP controller built-in PHY, > + * no extra PHY configuration is required. > + */ > + dp->phy = devm_phy_optional_get(dp->dev, "dp"); > + if (IS_ERR(dp->phy)) > + return ERR_CAST(dp->phy); [Severity: Low] Are this comment and the commit message accurate about RK3288? In arch/arm/boot/dts/rockchip/rk3288.dtsi and Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml, the RK3288 eDP node defines phys = <&edp_phy> and phy-names = "dp" for its rockchip,rk3288-dp-phy device, which drivers/phy/rockchip/phy-rockchip-dp.c programs via GRF_SOC_CON12 when phy_power_on() and phy_power_off() are called on dp->phy. RK3399 and RK3568 are the variants that omit the phys property and configure the built-in PHY directly through the controller MMIO registers rather than through a separate PHY device or GRF. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
