Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/sun4i: stale @map kernel-doc entry on struct sun8i_mixer_cfg --
commit 4d9d59875c066497d13ed0e8e40a5cc35799a204 Author: Jernej Skrabec <[email protected]> drm/sun4i: Switch DE33 to split plane bindings This commit switches DE33 mixer discovery to use the shared plane driver and split register bindings, removing the legacy per-mixer DE33 plane setup. > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h > b/drivers/gpu/drm/sun4i/sun8i_mixer.h > index e2f83301aae8d..7abc88c898d92 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h > @@ -202,7 +202,6 @@ struct sun8i_mixer_cfg { > int ui_num; > unsigned int de_type; > unsigned long mod_rate; > - unsigned int map[6]; > }; [Severity: Low] Should the @map entry in the kernel-doc comment above struct sun8i_mixer_cfg also be removed? Leaving it causes scripts/kernel-doc (and W=1 builds) to warn about an excess struct member description. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
