On Sun, Nov 15, 2026 at 2:27 PM <[email protected]> wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Medium] clk: sunxi-ng: de2: missing select REGMAP_MMIO for > SUN8I_DE2_CCU
Added while applying. > -- > > commit d1c006fcc75e6e1facbfb7f265581bef0d4d672a > Author: Jernej Skrabec <[email protected]> > > clk: sunxi-ng: de2: Export register regmap for DE33 > > This commit removes the hardcoded DE33 plane mapping writes from the clock > driver and exports those registers via an MMIO regmap instead. > > > diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c > > b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c > > index 6ec6c0dc4c261..f17570efafaae 100644 > > --- a/drivers/clk/sunxi-ng/ccu-sun8i-de2.c > > +++ b/drivers/clk/sunxi-ng/ccu-sun8i-de2.c > > [ ... ] > > > @@ -336,13 +367,19 @@ static int sunxi_de2_clk_probe(struct platform_device > > *pdev) > > } > > > > /* > > - * The DE33 requires these additional (unknown) registers set > > + * The DE33 requires these additional plane mapping registers set > > * during initialisation. > > */ > > if (of_device_is_compatible(pdev->dev.of_node, > > "allwinner,sun50i-h616-de33-clk")) { > > - writel(0, reg + 0x24); > > - writel(0x0000a980, reg + 0x28); > > + struct regmap *regmap; > > + > > + regmap = devm_regmap_init_mmio(&pdev->dev, reg, > > + &sun8i_de2_ccu_regmap_config); > > + if (IS_ERR(regmap)) { > > + ret = PTR_ERR(regmap); > > + goto err_assert_reset; > > + } > > } > > [Severity: Medium] > Should SUN8I_DE2_CCU select REGMAP_MMIO in drivers/clk/sunxi-ng/Kconfig? > > Without it, enabling SUN8I_DE2_CCU when REGMAP_MMIO is disabled (for > example under COMPILE_TEST=y with ARCH_SUNXI=n) or built as a module with > SUN8I_DE2_CCU=y breaks compilation on sun8i_de2_ccu_regmap_config or fails > to link __devm_regmap_init_mmio_clk(). > > -- > Sashiko AI review · > https://sashiko.dev/#/patchset/[email protected]?part=2 >
