On Mon, Nov 16, 2026 at 05:31:39PM +0200, Laurent Pinchart wrote:
> Hi Frank,
>
> On Mon, Nov 16, 2026 at 10:25:11AM -0500, [email protected] wrote:
> > From: Frank Li <[email protected]>
> >
> > The stub for pm_runtime_get_if_in_use() under !CONFIG_PM currently
> > returns -EINVAL.  The real implementation returns:
> >   1  - device is active and its usage counter is non-zero (bumped)
> >   0  - device is not in use or not active (counter not bumped)
> >  -EINVAL - runtime PM disabled for this device
> >
> > When CONFIG_PM is not set every device is permanently "active" and
> > always considered "in use", so the stub must return 1, mirroring
> > __pm_runtime_resume() which already returns 1 in the same build.
> >
> > Returning -EINVAL breaks callers that test the return value with
> > comparisons other than "!= 0 / == 0":
> >
> > drivers/gpu/drm/i915/intel_runtime_pm.c:
> >   if (intel_runtime_pm_get_if_in_use(rpm))
> >   which wraps to: ret = pm_runtime_get_if_in_use(); return ret > 0;
> >   With -EINVAL the wrapper returns false, causing an incorrect error
> >   path in the GT fence revocation code.
> >
> > drivers/gpu/drm/xe/xe_pm.c:
> >   if (pm_runtime_get_if_in_use(xe->drm.dev) > 0)
> >   With -EINVAL the condition is false; xe_pm_runtime_get_if_in_use()
> >   returns false, so callers believe the device is not usable.
> >
> > drivers/gpu/drm/gma500/power.c:
> >   return pm_runtime_get_if_in_use(dev) == 1;
> >   -EINVAL != 1, so the helper always returns false when !CONFIG_PM.
> >
> > drivers/gpu/drm/imagination/pvr_power.c:
> >   if (pm_runtime_get_if_in_use(...) <= 0)
> >   -EINVAL <= 0 is true, so the driver always takes the "requeue" error
> >   path instead of proceeding with the active device.
> >
> > sound/soc/sof/debug.c:
> >   if (pm_runtime_get_if_in_use(sdev->dev) == 1)
> >   -EINVAL != 1, so d3_prevented is never set, corrupting exception
> >   debug accounting.
> >
> > drivers/iommu/mtk_iommu.c:
> >   if (pm_runtime_get_if_in_use(dom->plat_dev->dev) <= 0)
> >   -EINVAL <= 0 skips the TLB flush, leaving stale IOMMU mappings.
> >
> > drivers/iommu/rockchip-iommu.c:
> >   Three call sites use WARN_ON_ONCE(err < 0) or similar patterns.
> >   -EINVAL < 0 triggers a spurious WARNING on every call.
> >
> > drivers/media/i2c/isl7998x.c:
> >   if (pm_runtime_get_if_in_use(dev) <= 0)  (two call sites)
> >   -EINVAL <= 0 causes the driver to always skip register programming
> >   when !CONFIG_PM.
> >
> > drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:
> >   if (pm_runtime_get_if_in_use(dev) <= 0)  (two call sites)
> >   -EINVAL <= 0 prevents any debug statistics from being collected.
> >
> > Fixes: 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM 
> > logic")
> > Fixes: cbb6a7413b17 ("drm/xe: Introduce xe_pm_runtime_get_noresume for 
> > inner callers")
> > Fixes: 672c473576ca ("drm/gma500: Rewrite power management code")
> > Fixes: 727538a4bbff ("drm/imagination: Implement power management")
> > Fixes: b30289e7fa92 ("ASoC: SOF: Fix runtime pm usage counter balance after 
> > fw exception")
> > Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation")
> > Fixes: 0f181d3cf7d9 ("iommu/rockchip: Add runtime PM support")
> > Fixes: 51ef2be546e2 ("media: i2c: isl7998x: Add driver for Intersil 
> > ISL7998x")
> > Fixes: cbb819c363c5 ("media: rkisp1: debug: Collect input status by 
> > sampling ISP_FLAGS_SHD")
>
> I don't think this one is right. The rkisp1 driver only runs on ARCH_MXC
> and ARCH_ROCKCHIP, which select CONFIG_PM. The same may be true for some
> of the other fixes tags.

But code itself should be wrong even though these platform force enable
CONFIG_PM.

Frank

>
> > Signed-off-by: Frank Li <[email protected]>
> > ---
> > Change in v2
> > - new patches.
> >
> > Cc: "Rafael J. Wysocki" <[email protected]>
> > Cc: [email protected]
> > Cc: Jani Nikula <[email protected]>
> > Cc: Joonas Lahtinen <[email protected]>
> > Cc: Rodrigo Vivi <[email protected]>
> > Cc: Tvrtko Ursulin <[email protected]>
> > Cc: Maarten Lankhorst <[email protected]>
> > Cc: Maxime Ripard <[email protected]>
> > Cc: "Thomas Hellstrom" <[email protected]>
> > Cc: Simona Vetter <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: Matthew Brost <[email protected]>
> > Cc: Thomas Zimmermann <[email protected]>
> > Cc: Patrik Jakobsson <[email protected]>
> > Cc: Alessio Belle <[email protected]>
> > Cc: Luigi Santivetti <[email protected]>
> > Cc: Liam Girdwood <[email protected]>
> > Cc: Mark Brown <[email protected]>
> > Cc: Jaroslav Kysela <[email protected]>
> > Cc: Takashi Iwai <[email protected]>
> > Cc: Bard Liao <[email protected]>
> > Cc: Pierre-Louis Bossart <[email protected]>
> > Cc: Peter Ujfalusi <[email protected]>
> > Cc: Kai Vehmanen <[email protected]>
> > Cc: Robin Murphy <[email protected]>
> > Cc: Yong Wu <[email protected]>
> > Cc: AngeloGioacchino Del Regno <[email protected]>
> > Cc: Matthias Brugger <[email protected]>
> > Cc: Heiko Stuebner <[email protected]>
> > Cc: Mauro Carvalho Chehab <[email protected]>
> > Cc: Dafna Hirschfeld <[email protected]>
> > Cc: Laurent Pinchart <[email protected]>
> > Cc: Michael Tretter <[email protected]>
> > Cc: Daniel Baluta <[email protected]>
> > Cc: Will Deacon <[email protected]>
> > Cc: Vijendar Mukunda <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > ---
> >  include/linux/pm_runtime.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> > index de9e7518ecef2..1d983fe55a16a 100644
> > --- a/include/linux/pm_runtime.h
> > +++ b/include/linux/pm_runtime.h
> > @@ -276,7 +276,7 @@ static inline int pm_schedule_suspend(struct device 
> > *dev, unsigned int delay)
> >  }
> >  static inline int pm_runtime_get_if_in_use(struct device *dev)
> >  {
> > -   return -EINVAL;
> > +   return 1;
> >  }
> >  static inline int pm_runtime_get_if_active(struct device *dev)
> >  {
>
> --
> Regards,
>
> Laurent Pinchart

Reply via email to