Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] PM: runtime: inaccurate Fixes trailers and caller analysis in commit message --
commit ef3656b915b0fdf6f58ce6d87b9638c3f1514d1a Author: Frank Li <[email protected]> > PM: runtime: fix stub pm_runtime_get_if_active() for !CONFIG_PM > > When CONFIG_PM is not enabled, should be treated as if runtime PM were > enabled for the device and the runtime status is active. > > It's a subtle distinction but the previous behavior returned -EINVAL, which > means "runtime PM is disabled for the device" > > __pm_runtime_resume() returns 1 (called by pm_runtime_get()). > pm_runtime_get_if_active() is the try-and-get version of pm_runtime_get(). > stub pm_runtime_active() also returns true. So pm_runtime_get_if_active() > should return the same value as the stub pm_runtime_get(), which is 1. > > Analysis of all callers and their behavior with old (-EINVAL) vs new (1): > > Pattern A: if (!pm_runtime_get_if_active(dev)) -- no impact > Both -EINVAL and 1 are non-zero, so !ret is false in both cases. > Callers: drivers/accel/ethosu/ethosu_perfmon.c, > drivers/gpu/drm/msm/adreno/a6xx_gmu.c, > drivers/gpu/drm/msm/msm_perfcntr.c, > drivers/gpu/drm/v3d/v3d_mmu.c, > drivers/gpu/drm/v3d/v3d_perfmon.c (x4), > drivers/media/i2c/gc08a3.c gc05a2.c og0ve1b.c ov6211.c, > drivers/media/i2c/ccs/ccs-core.c s5kjn1.c lm3560.c (x2), > drivers/media/i2c/s5k3m5.c thp7312.c imx283.c ov64a40.c, > drivers/media/pci/intel/ipu6/ipu6-buttress.c, > sound/hda/core/device.c > > Pattern B: if (!ret) after get -- no impact > Both -EINVAL and 1 are non-zero, !ret is false in both cases. > drivers/gpu/drm/amd/pm/amdgpu_pm.c (comment says "allow access" > in kernels without CONFIG_PM), drivers/pci/pci.c > > Pattern C: ret > 0 / ret <= 0 / ret != 1 checks -- FIXED > drivers/usb/core/offload.c: checks (!= 1), old -EINVAL caused > -EBUSY even with !CONFIG_PM. Fixed: now returns 1, proceeds. > drivers/accel/ivpu/ivpu_job.c: drm_WARN_ON(<= 0), old -EINVAL > spuriously triggered WARN. Fixed: 1 > 0, no warn. > drivers/gpu/drm/i915/intel_runtime_pm.c: checks (<= 0), old > -EINVAL triggered error path. Fixed: 1 > 0, correct path. > drivers/accel/ivpu/ivpu_sysfs.c: (> 0), old skipped freq read. > Fixed: proceeds correctly without CONFIG_PM. > drivers/gpu/drm/xe/xe_pm.c: wraps (> 0), all xe callers > (xe_bo.c, xe_shrinker.c, xe_vsec.c, xe_ggtt.c, xe_guc_ct.c, > xe_pxp.c) now correctly treat !CONFIG_PM as active. > drivers/net/ipa/ipa_smp2p.c: power_on = (> 0), now correctly true. > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c: (> 0), now correctly > executes stall register update. > drivers/staging/media/ipu7/ipu7-buttress.c: active (<= 0) early > return now skipped, correctly proceeds. > > Pattern D: explicit -EINVAL check > drivers/hwmon/prom21-xhci.c: checks (> 0) then (== -EINVAL). > Old: took -EINVAL fallback. New: takes (> 0) fast path. > Both succeed when CONFIG_PM is disabled; functionally equivalent. > drivers/hwmon/eic7700-pvt.c: call is guarded by IS_ENABLED(CONFIG_PM), > stub is never reached. No impact. > > Fixes: bd3d245b0fef5 ("usb: core: use dedicated spinlock for offload state") > Fixes: 7806bad76ac39 ("accel/ivpu: Prevent runtime suspend during context > abort work") > Fixes: 9d58aa46291d4 ("drm/i915: Fix the GT fence revocation runtime PM > logic") > Fixes: 1524c28b99527 ("accel/ivpu: Show NPU frequency in sysfs") > Fixes: 30c399529f4c6 ("drm/xe: Document Xe PM component") > Fixes: 0d08026ac6099 ("net: ipa: kill ipa_clock_get_additional()") > Fixes: 70892277ca2db ("iommu/arm-smmu-qcom: Make set_stall work when the > device is on") > Fixes: 9ad65684b9285 ("media: staging/ipu7: Ignore interrupts when device is > suspended") > Acked-by: Alex Elder <[email protected]> > Signed-off-by: Frank Li <[email protected]> [Severity: Low] Are some of the Fixes: tags and caller notes in the commit message pointing to the wrong commits or config guards? The !CONFIG_PM stub for pm_runtime_get_if_active() was introduced returning -EINVAL in c111566bea7c ("PM: runtime: Add pm_runtime_get_if_active()") and updated in c0ef3df8dbae ("PM: runtime: Simplify pm_runtime_get_if_active() usage"), neither of which is listed in Fixes:. For the caller-specific tags and descriptions: - 30c399529f4c ("drm/xe: Document Xe PM component") only touched kernel-doc comments; the > 0 check in xe_pm_runtime_get_if_active() came from 46edb0a3eb16 ("drm/xe: Fix xe_pm_runtime_get_if_active return"). - In __intel_runtime_pm_get_if_active() in drivers/gpu/drm/i915/intel_runtime_pm.c, the pm_runtime_get_if_active() call is guarded by if (IS_ENABLED(CONFIG_PM)), so the !CONFIG_PM stub is never reached there and 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM logic") was not affected. Similarly, snd_hdac_keep_power_up() in sound/hda/core/device.c is inside #ifdef CONFIG_PM and also checks if (ret < 0). - 0d08026ac609 ("net: ipa: kill ipa_clock_get_additional()") only inlined ipa_clock_get_additional() into ipa_smp2p_notify(); the pm_runtime_get_if_active() > 0 check was introduced in a71aeff3dd0a ("net: ipa: kill IPA clock reference count"). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
