Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] dt-bindings: soc: amlogic: unwieldy conditionals in meson-gx-hhi-sysctrl.yaml --
commit 2922cae8c47e87d6a0fd71e91e4a07690e4d0f66 Author: Ronald Claveau <[email protected]> dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node This commit adds an optional hdmi-phy child node to the Amlogic Meson system controller binding for amlogic,meson-gx-hhi-sysctrl and forbids it on the other system controller variants. > diff --git > a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > > b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > index 285edac4c0821..97e47592aff2e 100644 > --- > a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > +++ > b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > @@ -36,6 +36,9 @@ properties: > phy: > type: object > > + hdmi-phy: > + $ref: /schemas/phy/amlogic,meson-hdmi-tx-phy.yaml > + > allOf: > - if: > properties: > @@ -50,6 +53,7 @@ allOf: > > pinctrl: false > phy: false > + hdmi-phy: false > > - if: > properties: > @@ -80,6 +84,7 @@ allOf: > > power-controller: false > phy: false > + hdmi-phy: false > > - if: > properties: > @@ -104,6 +109,7 @@ allOf: > oneOf: > - $ref: /schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml > - $ref: /schemas/phy/amlogic,meson-axg-mipi-pcie-analog.yaml > + hdmi-phy: false [Severity: Low] Would it make sense to split these system controller variants into separate schema documents instead of adding more per-compatible exclusions here? This schema covers five system controller compatibles across different SoC families and register blocks (HHI and AO), where nearly every child node property (clock-controller, power-controller, pinctrl, phy, and now hdmi-phy) differs across variants and has to be overridden or forbidden in overlapping allOf if-then branches. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
