Hi, On Sat, Nov 14, 2026 at 5:54 AM Archit More <[email protected]> wrote: > > In commit 3944ca3e6b7d ("drm/panel: newvision-nv3051d: Use > mipi_dsi_*_multi(); fix minor bugs"), prepare() and unprepare() were > converted to use mipi_dsi_*_multi() helpers, but > panel_nv3051d_init_sequence() continued using its own local struct > mipi_dsi_multi_context and unconditionally returned 0. Consequently, > errors encountered during the panel init sequence were discarded and > never reached prepare(). > > Convert panel_nv3051d_init_sequence() to take struct > mipi_dsi_multi_context * directly from prepare() so all DCS commands > share the same context. Referred to panel-elida-kd35t133 to solve > the issue. > > Signed-off-by: Archit More <[email protected]> > --- > .../gpu/drm/panel/panel-newvision-nv3051d.c | 383 +++++++++--------- > 1 file changed, 187 insertions(+), 196 deletions(-)
When applying, `b4` added the "Fixes:" tag that sashiko mentioned. With the tag added: Reviewed-by: Douglas Anderson <[email protected]> I'll also note that on some similar drivers we've also had a followup patch to change hex numbers to lowercase (0xAB to 0xab, for example). If you feel like another small cleanup, I wouldn't oppose seeing that. Given that this was found by code inspection, I don't feel this is critical enough for drm-misc-fixes, so I'm putting it in drm-misc-next. Pushed to drm-misc-next: [1/1] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare() commit: a3621d124f7b1c4d6d31a68fe096d287b52bbdae
