From: Ville Syrjälä <[email protected]>

The overlay names its two graph endpoints "endpoint@0" but gives them
no reg property, so dtc complains with W=1:

  Warning (unit_address_vs_reg): .../endpoint@0: node has a unit name,
  but no reg or ranges property

There is only one endpoint per port, and the overlay refers to the
nodes through the panel_in and lcd_0 labels, not by name. Use plain
"endpoint" for the node names, which is the usual form for a single
endpoint, and drop the bogus unit address. The remote-endpoint
phandle links between the two nodes are unchanged.

Fixes: 0ff223d99147 ("drm/tilcdc: Convert legacy panel binding via DT overlay 
at boot time")
Cc: Kory Maincent <[email protected]>
Cc: Jyri Sarha <[email protected]>
Cc: Tomi Valkeinen <[email protected]>
Signed-off-by: Ville Syrjälä <[email protected]>
---
Caveat! I really have no clue about DT, so this was pretty
much all Claude's idea how to fix the warning. I'd buy what
it's selling, but can't really judge it one way or the other.
Nor can I actually test this.

 drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.dtso | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.dtso 
b/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.dtso
index ae71d10f5ec1..ca82f3bed15c 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.dtso
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.dtso
@@ -13,7 +13,7 @@
        tilcdc-panel-dpi {
                compatible = "panel-dpi";
                port {
-                       panel_in: endpoint@0 {
+                       panel_in: endpoint {
                                remote-endpoint = <&lcd_0>;
                        };
                };
@@ -22,7 +22,7 @@ panel_in: endpoint@0 {
 
 &lcdc {
        port {
-               lcd_0: endpoint@0 {
+               lcd_0: endpoint {
                        remote-endpoint = <&panel_in>;
                };
        };
-- 
2.56.0

Reply via email to