Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/imagination: COMPILE_TEST build failure on 64-bit
  8KB/32KB page configs
--

commit 3a0a5d98906b6758538e2c13acfa780422a1a949
Author: Ville Syrjälä <[email protected]>

drm/imagination: Allow build with COMPILE_TEST=y

This commit allows DRM_POWERVR to be built on any 64-bit architecture when
COMPILE_TEST is enabled.

> diff --git a/drivers/gpu/drm/imagination/Kconfig 
> b/drivers/gpu/drm/imagination/Kconfig
> index 1fd4c635c2c96..a048d3c859385 100644
> --- a/drivers/gpu/drm/imagination/Kconfig
> +++ b/drivers/gpu/drm/imagination/Kconfig
> @@ -3,7 +3,8 @@
>  
>  config DRM_POWERVR
>       tristate "Imagination Technologies PowerVR (Series 6 and later) & IMG 
> Graphics"
> -     depends on (ARM64 || RISCV && 64BIT)
> +     depends on ARM64 || RISCV || COMPILE_TEST
> +     depends on 64BIT
>       depends on DRM
>       depends on MMU
>       depends on PM

[Severity: Medium]
Does enabling DRM_POWERVR under COMPILE_TEST && 64BIT break the build on
64-bit targets with 8KiB or 32KiB pages (such as sparc64, alpha, or 64-bit
mips with PAGE_SIZE_8KB/PAGE_SIZE_32KB)?

drivers/gpu/drm/imagination/pvr_mmu.h defines PVR_DEVICE_PAGE_SIZE as
PAGE_SIZE, and drivers/gpu/drm/imagination/pvr_mmu.c only supports 4KiB,
16KiB, 64KiB, 256KiB, 1MiB, and 2MiB pages, failing with an #error on any
other host page size.  Should DRM_POWERVR also depend on !PAGE_SIZE_8KB &&
!PAGE_SIZE_32KB (or restrict to supported page sizes)?

-- 
Sashiko AI review · 
https://sashiko.dev/#/patchset/[email protected]?part=15

Reply via email to