Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/bridge_connector: check detect->type in
  drm_bridge_connector_detect_ctx()
--

commit c94cf087c06da031558bf281d88106d6134140dc
Author: Yongxing Mou <[email protected]>

drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort

This commit skips calling drm_bridge_connector_hpd_notify() from
drm_bridge_connector_detect_ctx() for DisplayPort connectors that have an
HPD bridge.

> diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c 
> b/drivers/gpu/drm/display/drm_bridge_connector.c
> index 1d4502126bff3..dbe874d26911b 100644
> --- a/drivers/gpu/drm/display/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/display/drm_bridge_connector.c
> @@ -315,7 +315,10 @@ static int drm_bridge_connector_detect_ctx(struct 
> drm_connector *connector,
>                               return ret;
>               }
>  
> -             drm_bridge_connector_hpd_notify(connector, status, 
> DRM_CONNECTOR_NO_EXTRA_STATUS);
> +             if (connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort 
> ||
> +                 !bridge_connector->bridge_hpd)
> +                     drm_bridge_connector_hpd_notify(connector, status,
> +                                                     
> DRM_CONNECTOR_NO_EXTRA_STATUS);

[Severity: Medium]
Should this check detect->type != DRM_MODE_CONNECTOR_DisplayPort instead of
connector->connector_type?

In drm_bridge_connector_init(), connector->connector_type is taken from the
last bridge in the chain rather than bridge_connector->bridge_detect.  When
msm_dp_bridge (detect->type == DRM_MODE_CONNECTOR_DisplayPort) is followed
by a Type-C HPD bridge that sets bridge.type = DRM_MODE_CONNECTOR_USB (such
as drivers/platform/arm64/acer-aspire1-ec.c), connector->connector_type is
DRM_MODE_CONNECTOR_USB.  When msm_dp_bridge_detect() returns
connector_status_disconnected (for example while MST is active),
drm_bridge_connector_detect_ctx() will still notify the bridge chain and
tear down the active DP link.

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=20

Reply via email to