On Fri, 20 Nov 2026 09:49:39 +0100 Geert Uytterhoeven <[email protected]> wrote:
> Hi Andreas, > > On Fri, 20 Nov 2026 at 09:44, Andreas Kemnade <[email protected]> wrote: > > On Fri, 20 Nov 2026 08:49:05 +0100 > > Geert Uytterhoeven <[email protected]> wrote: > > > On Thu, 19 Nov 2026 at 22:50, Andreas Kemnade <[email protected]> > > > wrote: > > > > On Thu, 19 Nov 2026 14:40:38 +0100 > > > > Geert Uytterhoeven <[email protected]> wrote: > > > > > > > > > OMAP2+ clock handling uses of_clk_get_from_provider() to obtain clocks > > > > > used for power management, so the latter show up as "deviceless" in > > > > > the > > > > > consumer column of the clk_summary file in debugfs. > > > > > > > > > > Fix this by using dev_clk_get_from_provider() instead, letting us pass > > > > > the consumer device, too. > > > > > > > > > > Signed-off-by: Geert Uytterhoeven <[email protected]> > > > > > --- > > > > > Compile-tested only. > > > > > > > > > > The first change is probably OK. The second change may fail if > > > > > anything > > > > > in the oh->od->pdev->dev chain is not available yet at this point. > > > > > > > > Test on OMAP3: > > > > > > Thanks for testing! > > > > > > > --- clk-old 2026-11-19 22:44:59.810807920 +0100 > > > > +++ clk-new 2026-11-19 22:26:52.862531880 +0100 > > > > @@ -1,17 +1,17 @@ > > > > enable prepare protect > > > > duty hardware connection > > > > clock count count count rate > > > > accuracy phase cycle enable consumer id > > > > > > > > --------------------------------------------------------------------------------------------------------------------------------------------- > > > > - oscillator 0 0 0 > > > > 26000000 0 0 50000 Y deviceless > > > > of_clk_get_from_provider > > > > + oscillator 0 0 0 > > > > 26000000 0 0 50000 Y deviceless > > > > dev_clk_get_from_provider > > > > > > > > deviceless > > > > no_connection_id > > deviceless > mcbsp_clks > > > > > > Hmm, so the passed device is always NULL, and thus there is no point > > > in making the change. > > > Do you know if these come from the first or second change in my patch > > > (I guess the second)? > > > > > From the first change, The second piece is nowadys only used by the dm81* > > devices. > > Interesting. So that means all/some of the existing use of > &od->pdev->dev in _add_clkdev() is futile, as it may be NULL? > I was wrong, it comes from neither. So lets start ftrace via cmdline... ftrace=function ftrace_filter=dev_clk_get_from_provider Piping the result through uniq -c 8 <idle>-0 [000] d.... 0.000000: dev_clk_get_from_provider <-ti_dt_clocks_register 66 <idle>-0 [000] d.... 0.000000: dev_clk_get_from_provider <-ti_clk_add_aliases 1 <idle>-0 [000] d.... 0.004913: dev_clk_get_from_provider <-of_clk_set_defaults 1 <idle>-0 [000] d.... 0.004974: dev_clk_get_from_provider <-of_clk_set_defaults Regards, Andreas
