On Thu, 7 Jun 2001, Brian Paul wrote:
> Pontus Hedman wrote:
> >
> > > Either submit the patch here if it's small enough, or submit
> > > to patches on the DRI sourceforge page.
> >
> > Ok; it's a trivial one-liner to r128ConvertTexture32bpp.
> > See below.
> >
> > It's probably more of a workaround than a fix
> > (the image passed in from r128UploadSubImage()
> > had dimensions but no Data for some reason),
> > but it beats having X lock up, and descent3
> > runs fine with this fix.
> >
> > Index: r128_tex.c
> > ===================================================================
> > RCS file: /cvsroot/dri/xc/xc/lib/GL/mesa/src/drv/r128/r128_tex.c,v
> > retrieving revision 1.20
> > diff -r1.20 r128_tex.c
> > 703c703
> > < if ( !image )
> > ---
> > > if ( !image || !image->Data)
> >
Brian,
I thought that in the C specs you can't be guarenteed the order of
evaluation in an if brace. Surely a safer bet is
if(!image){
if(!image->Data){
...
}
}
If you know better I stand corrected, I'm just thinking that not all
target platforms will use gcc (which I presume is the one that is used in
this case).
>
> This looks reasonable. I'll apply it to the trunk. This code
> has changed quite a bit in the 3.5 driver but I think it might
> be applicable there too.
>
> -Brian
>
> _______________________________________________
> Dri-devel mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/dri-devel
>
\\ - - //
( @ @ )
+---------------o00o----(_)----o00o-------------------------------------+
|Andy Richardson Dept. of Chemistry |
|t(w): +44 171 380 (7465) University college London |
|t(h): +44 181 352 (0848) Gordon street |
|e: [EMAIL PROTECTED] London WC1E 6BT UK |
+------------------------------0ooo-------------------------------------+
ooo0 ( )
( ) ) /
\ ( (_/
\_)
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/dri-devel
