On Mon, 2002-09-23 at 12:31, Keith Whitwell wrote: > Eric Anholt wrote: > > On Sat, 2002-09-21 at 07:21, Michel Dänzer wrote: > > > >>http://penguinppc.org/~daenzer/DRI/radeon-vblank.diff > >> > >>Let me know what you think about the interface in that patch, would be > >>great if we could make this a template. > >> > > > > Here's the patch with FreeBSD and r200 added (partially).
I've incorporated this and turned it into a template: http://penguinppc.org/~daenzer/DRI/drm-vblank-template.diff > > I've removed the bottom half from the irq handler in the FreeBSD case -- > > wakeups and a lot more can go in the top half in BSD just fine from > > what I've been told. > > This is an open question for me. Does linux require an irq bh just to do a > wake_up_interruptible? Could/should we do something equivalent from the tophalf? The above patch moves this to the top half as well. > > Would anything else ever get added to the handler (for vbl or > > other irq)? I can't imagine anything but checking for the cause of the IRQ and kicking something off accordingly. > > The r200 client lib doesn't check for the irq number, but I > > couldn't figure out what exactly that was being checked for. To see if the IRQ is enabled. > > Also, it seems the driver init macros should be functions. Is there any reason > > why they aren't? > > Because they didn't use to do much, or because the oringal pre-templated > version of the init functions had those bits of code inlined, so the obvious > transformation turned them into macros. There's nothing to stop us calling a > function from those macros. DRM(driver_preinstall) etc.? > One worry I have with the radeon_irq.c code at the moment is the proliferation > of ifdef's for linux vs. freebsd code. I'd like to see this get cleaned up -- > if nothing else it's ugly... It's not quite as bad with this patch, still we might want to define DRM_WAKEUP or similar. -- Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer XFree86 and DRI project member / CS student, Free Software enthusiast ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
