On Sun, 1 Dec 2002, Keith Whitwell wrote: > Felix Kühling wrote: > > Hi, > > > > I made two small modifications to the radeon driver to make OpenGL look > > much nicer with 16bpp. The first thing is to enable dithering, the > > second is to use 32bpp textures even in 16bpp mode, if the application > > requests them. A patch is attached. > > > > Maybe the texture color depth should be handled more intelligently in > > 16bpp mode, based on the amount of graphics memory or controlled by an > > environment variable? > > > > Regards, > > Felix > > > > __\|/__ ___ ___ ___ > > __Tschüß_______\_6 6_/___/__ \___/__ \___/___\___You can do anything,___ > > _____Felix_______\Ä/\ \_____\ \_____\ \______U___just not everything____ > > [EMAIL PROTECTED] >o<__/ \___/ \___/ at the same time! > > > > > > ------------------------------------------------------------------------ > > > > Index: radeon_state_init.c > > =================================================================== > > RCS file: /cvsroot/dri/xc/xc/lib/GL/mesa/src/drv/radeon/radeon_state_init.c,v > > retrieving revision 1.6 > > diff -u -r1.6 radeon_state_init.c > > --- radeon_state_init.c 25 Nov 2002 19:58:28 -0000 1.6 > > +++ radeon_state_init.c 1 Dec 2002 12:49:17 -0000 > > @@ -337,6 +337,8 @@ > > rmesa->hw.ctx.cmd[CTX_RB3D_CNTL] = (RADEON_PLANE_MASK_ENABLE | > > color_fmt | > > (1<<15)); > > + if (color_fmt == RADEON_COLOR_FORMAT_RGB565) > > + rmesa->hw.ctx.cmd[CTX_RB3D_CNTL] |= RADEON_DITHER_ENABLE; > > I'm pretty sure this is OK, but can you check what happens to conform and/or > glean after doing this? > > Glean is a sourceforge project, I'm not sure where you can download conform > from. If you can't find it, I'll do the conform check.
According to section 4.1.8 of the OpenGL 1.4 spec: "Initially, dithering is enabled" -- so that should always be the initial default. -- Leif Delgass http://www.retinalburn.net ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
