On Tuesday 11 May 2004 18:20, Dave Airlie wrote: > > Ick, you can't use "int" as an ioctl structure member, sorry. Please > > use the proper "__u16" or "__u32" value instead. > > I just looked at drm.h and nearly all the ioctls use int, this file is > included in user-space applications also at the moment, I'm worried > changing all ints to __u32 will break some of these, anyone on DRI list > care to comment?
Two possibilities, I think: - Tiny machines where sizeof(int) == 2. All modern machines have sizeof(int) == 4, even for 64-bit architectures, certainly all machines that linux runs on anyway. - Negative; u32 == unsigned int, not (signed) int. Old code might interpret a number greater than 2^31 as negative; new code might interpret a number less than zero as positive. This is probably a good opportunity to make sure we're doing appropriate range checks. Numbers that need to be signed should be marked as such, __s32. - ajax ------------------------------------------------------- This SF.Net email is sponsored by Sleepycat Software Learn developer strategies Cisco, Motorola, Ericsson & Lucent use to deliver higher performing products faster, at low TCO. http://www.sleepycat.com/telcomwpreg.php?From=osdnemail3 -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
